-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update package.py - fixed docker volume #183
Conversation
Fixed adding root/.ssh folder into docker command only when ssh_agent is enabled
Hi! Thanks for the PR. Could you please show the terraform code snippet which failed using the code in the |
Can this be merged in? I believe i am suffering from the same issue that this fixes. Thanks! |
@Ranchman42 I'm waiting for the example code update to prove this PR does what it should (see my comment above) |
This PR has been automatically marked as stale because it has been open 30 days |
This PR was automatically closed because of stale in 10 days |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixed adding root/.ssh folder into docker command only when ssh_agent is enabled.
Fixes #178
Description
When creating package in docker container there is a default docker command imported that adds /root/.ssh as volume. However in cases when you run this in a pipeline (like bitbucket) you don't have such volume available - importing of /root/.ssh/known_hosts should be only available when you want to use ssh agent.
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
projects